HomePhabricator

Merge #13197: util: warn about ignored recursive -includeconf calls

Description

Merge #13197: util: warn about ignored recursive -includeconf calls

Summary:
2352aa9 test: Ensure that recursive -includeconf produces appropriate warnings (Karl-Johan Alm)
c5bcc7d util: warn about recursive -includeconf arguments in configuration files (Karl-Johan Alm)

Pull request description:

This is a follow-up PR to #10267, and addresses https://github.com/bitcoin/bitcoin/pull/10267#issuecomment-387546144.

~~I am adding extra work for @jnewbery in #12755 here -- maybe I should just rebase on top of that, but not sure what the appropriate approach is here.~~

Tree-SHA512: 87f0c32436b70424e33616ffb88d7cb699f90d6a583a10237e224b28fc936d6a9df95536c8c52ee8546b3942da92b2a357e61bf87e00d1462bc10d46d3bee352

Backport of Core PR13197
https://github.com/bitcoin/bitcoin/pull/13197/

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4118

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 14 2018, 14:38
nakihitoCommitted on Sep 23 2019, 17:34
nakihitoPushed on Sep 23 2019, 17:41
Reviewer
Restricted Owners Package
Differential Revision
D4118: Merge #13197: util: warn about ignored recursive -includeconf calls
Parents
rSTAGINGd559f01c7769: Merge #13079: Fix rescanblockchain rpc to properly report progress
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/13092, tag: phabricator/base/13089