HomePhabricator

Check redeemScript size does not exceed 520 byte limit
787ee0c91394Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Check redeemScript size does not exceed 520 byte limit

redeemScripts >520bytes can't be spent due to the
MAX_SCRIPT_ELEMENT_SIZE limit; previously the addmultisigaddress and
createmultisig RPC calls would let you violate that limit unknowingly.

Also made the wallet code itself check the redeemScript prior to adding
it to the wallet, which in the (rare) instance that a user has added an
invalid oversized redeemScript to their wallet causes an error on
startup. The affected key isn't added to the wallet; other keys are
unaffected.

Details

Provenance
Peter Todd <pete@petertodd.org>Authored on Mar 11 2014, 02:43
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING4d79098ad548: Increase IsStandard() scriptSig length
Branches
Unknown
Tags
Unknown

Event Timeline

Peter Todd <pete@petertodd.org> committed rSTAGING787ee0c91394: Check redeemScript size does not exceed 520 byte limit (authored by Peter Todd <pete@petertodd.org>).May 8 2014, 04:55