HomePhabricator

re-fix feature_cltv.py

Description

re-fix feature_cltv.py

Summary:
The core version of this test relied on nonpush opcodes in scriptsig
and thus got heavily rewritten in D2120 in order to comply with ABC's
consensus sigpushonly rule. This cleans up / fixes the test.

  • Make it actually validate -1 CLTV before activation, like it used to.
  • Change confusing name spendtx to fundtx. fundtx is always valid, as it does not execute CLTV.
  • Integrate creation of the actual spending tx at the same time (DRY).
  • Restore code that actually uses promiscuousmempoolflags; fix comment that inaccurately refers to promiscuousmempoolflags .
  • Simplify the ending.

Test Plan: test_runner.py feature_cltv.py

Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3095

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on May 23 2019, 14:15
MengerianPushed on May 23 2019, 15:52
Reviewer
Restricted Project
Differential Revision
D3095: re-fix feature_cltv.py
Parents
rSTAGING1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rSTAGING7af708e9f744: re-fix feature_cltv.py (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).May 23 2019, 14:15