HomePhabricator

[CMAKE] Remove extra -fPIE flag

Description

[CMAKE] Remove extra -fPIE flag

Summary:
Since cmake 3.8.2, the -fPIE flag is managed by cmake and added to the
compilation flags if POSITION_INDEPENDENT_CODE is ON. Adding it
manually is redundant at most, and error prone at worst.
Note that the -pie linker flag still needs to be added manually until
cmake 3.14+ is enforced.

Test Plan:

# You may need to clear your ccache
cmake -GNinja ..
ninja check-security

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4948

Details

Provenance
FabienAuthored on Jan 15 2020, 14:54
FabienPushed on Jan 15 2020, 17:04
Reviewer
Restricted Project
Differential Revision
D4948: [CMAKE] Remove extra -fPIE flag
Parents
rSTAGING6d8c162de5fb: [secp256k1] scratch: add stack frame support
Branches
Unknown
Tags
Unknown