HomePhabricator

build: prune dbus from depends

Description

build: prune dbus from depends

Summary:

Since #8210 (59d063d), we've been passing -dbus-runtime when configuring
Qt.

qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
  -no-dbus ............. Do not build the Qt D-Bus module
  -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
  -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1
[no]

This means we don't actually seem to be using the D-Bus we build in
depends. This was pointed out by theuni at the time, here and here, but
was never followed up. dongcarl also bought it up as part of #16150.

Backport of core PR16352.

Test Plan: Run the Linux Gitian builds.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5625

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Jul 7 2019, 06:26
FabienCommitted on Apr 1 2020, 07:24
FabienPushed on Apr 1 2020, 09:47
Reviewer
Restricted Project
Differential Revision
D5625: build: prune dbus from depends
Parents
rSTAGING7336644abe0c: depends: xtrans: Configure flags cleanup.
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/17349, tag: phabricator/base/17348, tag: phabricator/base/17347, tag: phabricator/base/17346