HomePhabricator

CreateNewBlock: insert entries into block slightly earlier so that correct size…

Description

CreateNewBlock: insert entries into block slightly earlier so that correct size is logged

Summary:
I noticed the log message was always printing "CreateNewBlock(): total size: 81 ...",
which is a bit silly.

This moves the pblock population back to where it belongs, right after the
entries are determined. To make this work, the coinbase tx is inserted
into pblock directly which is also what we want (and this goes back to what
Core does).

Test Plan: ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5019

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Jan 18 2020, 16:16
FabienPushed on Jan 21 2020, 14:48
Reviewer
Restricted Project
Differential Revision
D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged
Parents
rSTAGING98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`
Branches
Unknown
Tags
Unknown