HomePhabricator

Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py

Description

Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py

Summary:
There was a bug discovered by the addition of D4255 affecting ASAN
builds. See core issue:
https://github.com/bitcoin/bitcoin/issues/14163. The exact solution
for this bug is unclear, but will likely require the backporting of at
least the following PRs and their dependencies from Core:

https://github.com/bitcoin/bitcoin/pull/13161/
https://github.com/bitcoin/bitcoin/pull/12493/
https://github.com/bitcoin/bitcoin/pull/14320/
https://github.com/bitcoin/bitcoin/pull/14552/
https://github.com/bitcoin/bitcoin/pull/14760/
https://github.com/bitcoin/bitcoin/pull/11911/

Suppression of the error is a temporary fix until the above backports
are complete. This is the same approach that Core took. See
https://github.com/bitcoin/bitcoin/pull/14794/files#diff-354f30a63fb0907d4ad57269548329e3R111
for the initial suppression and
https://github.com/bitcoin/bitcoin/pull/15303/files#diff-354f30a63fb0907d4ad57269548329e3L128
for its removal.

Test Plan:
From the build dir:

export ABC_BUILD_NAME=build-asan
../contrib/teamcity/build-configurations.sh

ASAN build through TeamCity

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4281

Details

Provenance
nakihitoAuthored on Oct 23 2019, 01:01
nakihitoPushed on Oct 24 2019, 17:49
Reviewer
Restricted Owners Package
Differential Revision
D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py
Parents
rSTAGINGc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/13692, tag: phabricator/base/13689, tag: phabricator/base/13688