Diffusion Bitcoin ABC staging 8a7143e1c26e

Split key_io (address/key encodings) off from base58
8a7143e1c26e
Actions

Description

Split key_io (address/key encodings) off from base58

Summary:
This is a partial backport of Core PR11372 : https://github.com/bitcoin/bitcoin/pull/11372/commits/119b0f85e2c8b9729228aad5d946144d57ad0f5b

It was altered to support CashAddr.

Depends on D3573 and D3576

Test Plan:

make check

Reviewers: #bitcoin_abc, markblundeberg

Reviewed By: #bitcoin_abc, markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D3577

Details

Provenance

Pieter Wuille <pieter.wuille@gmail.com>	Authored on Sep 20 2017, 01:12
deadalnix	Committed on Jul 8 2019, 12:28
deadalnix	Pushed on Jul 8 2019, 14:00

Reviewer

Restricted Project

Differential Revision

D3577: Split key_io (address/key encodings) off from base58

Parents

rSTAGINGe61a3659d2b3: Stop using CBase58Data for ext keys

Branches

Unknown

Tags

Unknown

References

tag: phabricator/base/10087

Event Timeline

deadalnix added an edge: D3577: Split key_io (address/key encodings) off from base58.Sep 19 2019, 01:02

deadalnix committed rSTAGING8a7143e1c26e: Split key_io (address/key encodings) off from base58 (authored by Pieter Wuille <pieter.wuille@gmail.com>).Jul 8 2019, 12:28

Changes (42)

Path

Size

src/

	key_io.cpp
	base58.cpp

key_io.h

qt/

addresstablemodel.cpp

bitcoinaddressvalidator.cpp

coincontroldialog.cpp

guiutil.cpp

paymentrequestplus.cpp

paymentrequestplus.h

paymentserver.cpp

sendcoinsdialog.cpp

signverifymessagedialog.cpp

test/

guiutiltests.cpp

paymentservertests.cpp

wallettests.cpp

transactiondesc.cpp

transactionrecord.cpp

rpc/

test/

wallet/

rSTAGING8a7143e1c26e

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/base58.cpp

View Options

src/base58.h

View Options

src/bitcoin-tx.cpp

View Options

src/core_write.cpp

View Options

src/dstencode.cpp

View Options

src/dstencode.h

View Options

src/httprpc.cpp

View Options

src/key_io.cpp

View Options

src/key_io.h

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/bitcoinaddressvalidator.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentrequestplus.h

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/test/guiutiltests.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/base58_tests.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/dstencode_tests.cpp

View Options

src/test/key_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/sigcache_tests.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.cpp

View Options

Split key_io (address/key encodings) off from base588a7143e1c26eActions

Description

Details

Event Timeline

Changes (42)

rSTAGING8a7143e1c26e

src/CMakeLists.txt

src/Makefile.am

src/base58.cpp

src/base58.h

src/bitcoin-tx.cpp

src/core_write.cpp

src/dstencode.cpp

src/dstencode.h

src/httprpc.cpp

src/key_io.cpp

src/key_io.h

src/qt/addresstablemodel.cpp

src/qt/bitcoinaddressvalidator.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentrequestplus.h

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/signverifymessagedialog.cpp

src/qt/test/guiutiltests.cpp

src/qt/test/paymentservertests.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/base58_tests.cpp

src/test/bip32_tests.cpp

src/test/bloom_tests.cpp

src/test/dstencode_tests.cpp

src/test/key_tests.cpp

src/test/rpc_tests.cpp

src/test/sigcache_tests.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

Split key_io (address/key encodings) off from base58
8a7143e1c26e
Actions