HomePhabricator

Generic TransactionSignatureCreator works with both CTransaction and…

Authored by Martin Ankerl <martin.ankerl@gmail.com> on May 20 2018, 20:47.

Description

Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction

Summary:
Templated version so that no copying of CMutableTransaction into a CTransaction is
necessary. This speeds up the test case transaction_tests/test_big_witness_transaction
from 7.9 seconds to 3.1 seconds on my machine.

This is a backport of Core PR13309

Test Plan:

make check
./src/bench/bench_bitcoin

Reviewers: #bitcoin_abc, jasonbcox, Fabien

Reviewed By: #bitcoin_abc, jasonbcox, Fabien

Subscribers: Fabien, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4200

Details

Committed
deadalnixFri, Oct 4, 21:34
Pushed
deadalnixSat, Oct 5, 19:09
Reviewer
Restricted Project
Differential Revision
D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction
Parents
rSTAGING53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA
Branches
Unknown
Tags
Unknown