HomePhabricator

Added 'immature balance' for miners. Only displayed if the balance is greater…
8fdb7e108fbeUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Added 'immature balance' for miners. Only displayed if the balance is greater than zero.

This adds a field labelled 'Immature' in the overview section under the 'unconfirmed' field, which shows mined
income that has not yet matured (which is currently not displayed anywhere, even though the transactions
exist in the transaction list). To do that I added a 'GetImmatureBalance' method to the wallet, and connected
that through to the GUI as per the 'GetBalance' and 'GetUnconfirmedBalance' methods. I did a small 'no-op'
change to make the code in adjacent functions a little more readable (imo); it was a change I had made in my
repo earlier...but I thought it wouldn't hurt so left it in. Immature balance comes from mined income that is
at least two blocks deep in the chain (same logic as displayed transactions).

My reasoning is:

  • as a miner, it's a critical stat I want to see
  • as a miner, and taking into account the label 'immature', the uncertainty is pretty clearly implied
  • those numbers are already displayed in the transaction list
  • this makes the overview numbers add up to what's in the transaction list
  • it's not displayed if the immature balance is 0, so won't bother non-miners

I also 'cleaned' the overview UI a little, moving code to the XML and removing HTML.

Details

Provenance
sje397 <sje397@gmail.com>Authored on Feb 14 2012, 11:08
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING6b8a17119e30: Lots more Script unit test cases.
Branches
Unknown
Tags
Unknown