HomePhabricator

Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)

Description

Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)

Summary:
b602c9b3af tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

Add missing locking annotations and locks.

`mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8

Backport of Core PR14108
https://github.com/bitcoin/bitcoin/pull/14108/

Test Plan:

cmake -GNinja .. -DENABLE_WERROR=ON
ninja check

Also run build-werror and build-tsan builds.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4967

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Aug 31 2018, 12:32
nakihitoCommitted on Jan 17 2020, 19:38
nakihitoPushed on Jan 17 2020, 20:31
Reviewer
Restricted Owners Package
Differential Revision
D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)
Parents
rSTAGINGe65bde748260: Temporary fix for recent build flakiness
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/15626, tag: phabricator/base/15622, tag: phabricator/base/15621