HomePhabricator

optim: mark a few classes final

Description

optim: mark a few classes final

Summary:
Enable devirtualization opportunities by using the final specifier (C++11)

  • Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls
  • Declaring CReserveKey final enables devirtualization of one call

Core PR10809

Fixes T171

Test Plan: make check && test/functional/test_runner.py

Reviewers: schancel, deadalnix, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Subscribers: teamcity

Maniphest Tasks: T171

Differential Revision: https://reviews.bitcoinabc.org/D1016

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Jul 12 2017, 20:48
matiuCommitted on Jan 23 2018, 21:47
matiuPushed on Jan 23 2018, 23:48
Reviewer
Restricted Project
Differential Revision
D1016: optim: mark a few classes final
Parents
rSTAGING6ef41ed3a922: Remove Consensus::Params parameter from ContextualCheckBlock
Branches
Unknown
Tags
Unknown
Tasks
T171: Backport core PR 10809: optim: mark a few classes final