HomePhabricator

net: Add and document network messages in protocol.h
9bbe71b641e2Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

net: Add and document network messages in protocol.h

  • Avoids string typos (by making the compiler check)
  • Makes it easier to grep for handling/generation of a certain message type
  • Refer directly to documentation by following the symbol in IDE
  • Move list of valid message types to protocol.cpp: protocol.cpp is a more appropriate place for this, and having the array there makes it easier to keep things consistent.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Dec 7 2015, 14:31
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING5dc63ed1ca8a: Merge pull request #7179
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGING9bbe71b641e2: net: Add and document network messages in protocol.h (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Dec 10 2015, 11:14