HomePhabricator

Workaround for BN_bn2mpi reading/writing out of bounds
a06113b0c5aaUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Workaround for BN_bn2mpi reading/writing out of bounds

When OpenSSL's BN_bn2mpi is passed a buffer of size 4, valgrind
reports reading/writing one byte past it. I am unable to find
evidence of this behaviour in BN_bn2mpi's source code, so it may
be a spurious warning. However, this change is harmless, as only
the bignum with value 0 results in an mpi serialization of size 4.

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Feb 18 2012, 12:32
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING39231e91052b: don't allow -daemon in bitcoin-qt (changes only #defines)
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rSTAGINGa06113b0c5aa: Workaround for BN_bn2mpi reading/writing out of bounds (authored by Pieter Wuille <pieter.wuille@gmail.com>).Feb 18 2012, 12:32