HomePhabricator

Remove VC6 comment and pointless #ifdef'd benchmark code
b019ea17ec7cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove VC6 comment and pointless #ifdef'd benchmark code

We're in a wholly different world now, C++-compiler-wise.

Current std::stringstream implementations don't have the stated problem anymore,
and are just as fast as CDataStream.

The #ifdef'd block does not even compile anymore; CDataStream constructor changed,
and missing some std::. Also timing in whole seconds is also way too granular
to say anything sensible in such microbenchmarks. Just remove it,
it can always be found again in git history.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 9 2012, 15:12
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGeabc8f2c8171: Merge pull request #1803 from luke-jr/md2k7_license
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGINGb019ea17ec7c: Remove VC6 comment and pointless #ifdef'd benchmark code (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Sep 9 2012, 15:24