Diffusion Bitcoin ABC staging b60a395a83ae

Reduce the use of ClearArg and only guarantee that we clear forced args.
b60a395a83ae
Actions

Description

Reduce the use of ClearArg and only guarantee that we clear forced args.

Summary: This feature doesn't exist in Core, so reducing its surface make sense. It is not strictly limited to forced args at the moment, but the name provide intent and we'll get there after backporting Core PR15934 .

Test Plan:

make check

Updated test to reflect the new behavior.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5850

Details

Provenance

deadalnix	Authored on Apr 27 2020, 00:04
deadalnix	Pushed on Apr 27 2020, 12:53

Reviewer

Restricted Project

Differential Revision

D5850: Reduce the use of ClearArg and only guarantee that we clear forced args.

Parents

rSTAGING154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code

Branches

Unknown

Tags

Unknown

Event Timeline

deadalnix added an edge: D5850: Reduce the use of ClearArg and only guarantee that we clear forced args..May 5 2020, 19:08

deadalnix committed rSTAGINGb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args. (authored by deadalnix).Apr 27 2020, 12:28

Changes (5)

Path

Size

src/

test/

miner_tests.cpp

transaction_tests.cpp

util_tests.cpp

util/

system.cpp

system.h

rSTAGINGb60a395a83ae

View Options

src/test/miner_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/util/system.cpp

View Options

Reduce the use of ClearArg and only guarantee that we clear forced args.b60a395a83aeActions

Description

Details

Event Timeline

Changes (5)

rSTAGINGb60a395a83ae

src/test/miner_tests.cpp

src/test/transaction_tests.cpp

src/test/util_tests.cpp

src/util/system.cpp

src/util/system.h

Reduce the use of ClearArg and only guarantee that we clear forced args.
b60a395a83ae
Actions