HomePhabricator

Clean up RPCs that are disabled in safe-mode.
b60be6be4a87Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Clean up RPCs that are disabled in safe-mode.

This removes some inconsistencies in what worked and didn't work in
safemode. Now only RPCs involved in getting balances or sending
funds are disabled.

Previously you could mine but not submit blocks— but we may need more
blocks to resolve a fork that triggered safe mode in the first place,
and the non-submission was not reliable since some miners submit
blocks via multiple means. There were also a number of random commands
disabled that had nothing to do with the blockchain like verifymessage.

Thanks to earlz for pointing out that there were some moderately cheap
ways to maliciously trigger safe mode, which brought attention to
the fact that safemode wasn't used in a very intelligent way.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Jul 10 2014, 17:06
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGf2286a69a98d: Merge pull request #4190
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGINGb60be6be4a87: Clean up RPCs that are disabled in safe-mode. (authored by Gregory Maxwell <greg@xiph.org>).Jul 10 2014, 17:35