HomePhabricator

Catch exception by ref in wallettool.cpp

Description

Catch exception by ref in wallettool.cpp

Summary: Catching exception by value is a bad practice, notably because it can lead to slicing.

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5762

Details

Provenance
deadalnixAuthored on Apr 17 2020, 15:27
deadalnixPushed on Apr 18 2020, 07:09
Reviewer
Restricted Project
Differential Revision
D5762: Catch exception by ref in wallettool.cpp
Parents
rSTAGING5713adbef822: [cmake] Fix dependencies for functional test targets
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/18928