Diffusion Bitcoin ABC staging bcaa59bb2fbe

Hash the input of OP_CHECKDATASIG instead of expecting the user to do it.
bcaa59bb2fbe
Actions

Description

Hash the input of OP_CHECKDATASIG instead of expecting the user to do it.

Summary:
This is safer

Co-authored-by: Amaury Séchet <deadalnix@gmail.com>
Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan: Updated tests to reflect the change.

Reviewers: #bitcoin_abc, Mengerian, schancel, jasonbcox

Reviewed By: #bitcoin_abc, Mengerian, schancel, jasonbcox

Subscribers: schancel, Mengerian, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1646

Details

Provenance

deadalnix	Authored on Aug 12 2018, 21:14
deadalnix	Pushed on Aug 14 2018, 20:10

Reviewer

Restricted Project

Differential Revision

D1646: Hash the input of OP_CHECKDATASIG instead of expecting the user to do it.

Parents

rSTAGING3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees

Branches

Unknown

Tags

Unknown

Event Timeline

deadalnix committed rSTAGINGbcaa59bb2fbe: Hash the input of OP_CHECKDATASIG instead of expecting the user to do it. (authored by deadalnix).Aug 13 2018, 20:31

Changes (5)

Path

Size

src/

script/

interpreter.cpp

test/

checkdatasig_tests.cpp

data/

script_tests.json

script_tests.cpp

test/

functional/

abc-checkdatasig-activation.py

rSTAGINGbcaa59bb2fbe

View Options

src/script/interpreter.cpp

View Options

src/test/checkdatasig_tests.cpp

View Options

src/test/data/script_tests.json

View Options

src/test/script_tests.cpp

View Options

test/functional/abc-checkdatasig-activation.py

Hash the input of OP_CHECKDATASIG instead of expecting the user to do it.bcaa59bb2fbeActions

Description

Details

Event Timeline

Changes (5)

rSTAGINGbcaa59bb2fbe

src/script/interpreter.cpp

src/test/checkdatasig_tests.cpp

src/test/data/script_tests.json

src/test/script_tests.cpp

test/functional/abc-checkdatasig-activation.py

Hash the input of OP_CHECKDATASIG instead of expecting the user to do it.
bcaa59bb2fbe
Actions