HomePhabricator

Fix unit test error on OSX 10.9 using Apple LLVM v5.0.
bccd5324ab5bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix unit test error on OSX 10.9 using Apple LLVM v5.0.

Before the fix, there were 6 errors such as :
serialize_tests.cpp:77: error in "noncanonical": incorrect exception std::ios_base::failure is caught

It turns out that ex.what() returns following string instead of "non-canonical ReadCompactSize()"
"non-canonical ReadCompactSize(): unspecified iostream_category error"

After the fix, unit test passed.

The test ran using Apple LLVM v5.0 on OSX 10.9 and the unit test error happened because of different error messages by different compilers.

g++ --version on my development environment.

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.0.0
Thread model: posix

Details

Provenance
Kangmo <kangmo@nanolat.com>Authored on Dec 15 2013, 14:25
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING8a7606f35bf6: Merge pull request #3377
Branches
Unknown
Tags
Unknown

Event Timeline

Kangmo <kangmo@nanolat.com> committed rSTAGINGbccd5324ab5b: Fix unit test error on OSX 10.9 using Apple LLVM v5.0. (authored by Kangmo <kangmo@nanolat.com>).Dec 15 2013, 14:25