HomePhabricator

Remove redundant locks

Description

Remove redundant locks

Summary:

  • SetAddressBook(...) is locking cs_wallet internally
  • DelAddressBook(...) is locking cs_wallet internally

Backport of PR11733
https://github.com/bitcoin/bitcoin/pull/11733

Test Plan:
make check
test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2700

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Nov 21 2017, 09:17
nakihitoCommitted on Mar 18 2019, 20:37
nakihitoPushed on Mar 18 2019, 22:05
Reviewer
Restricted Owners Package
Differential Revision
D2700: Remove redundant locks
Parents
rSTAGING6a8115b98cca: Merge #12327: [gui] Defer coin control instancing
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/7728

Event Timeline

Nico Guiton <nico@bitframe.org> committed rSTAGINGbf97bcfb8254: Remove redundant locks (authored by practicalswift <practicalswift@users.noreply.github.com>).Mar 18 2019, 20:37