HomePhabricator

CBufferedFile: convert into a non-refcounted RAII wrapper
c9fb27da0a72Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

CBufferedFile: convert into a non-refcounted RAII wrapper

  • it now takes over the passed file descriptor and closes it in the destructor
  • this fixes a leak in LoadExternalBlockFile(), where an exception could cause the file to not getting closed
  • disallow copies (like recently added for CAutoFile)
  • make nType and nVersion private

Details

Provenance
Philip Kaufmann <phil.kaufmann@t-online.de>Authored on Sep 25 2014, 06:53
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING00eef5d6e9b0: Merge pull request #5017
Branches
Unknown
Tags
Unknown

Event Timeline

Philip Kaufmann <phil.kaufmann@t-online.de> committed rSTAGINGc9fb27da0a72: CBufferedFile: convert into a non-refcounted RAII wrapper (authored by Philip Kaufmann <phil.kaufmann@t-online.de>).Oct 2 2014, 08:46