HomePhabricator

Wallet locking fixes for -DDEBUG_LOCKORDER
ca4cf5cff6fbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Wallet locking fixes for -DDEBUG_LOCKORDER

Compiling with -DDEBUG_LOCKORDER and running the qa/rpc-test/ regression
tests uncovered a couple of wallet methods that should (but didn't)
acquire the cs_wallet mutext.

I also changed the AssertLockHeld() routine print to stderr and
abort, instead of printing to debug.log and then assert()'ing.
It is annoying to look in debug.log to find out which
AssertLockHeld is failing.

Details

Provenance
Gavin Andresen <gavinandresen@gmail.com>Authored on Feb 18 2014, 17:11
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING5c9932345976: Merge pull request #3693
Branches
Unknown
Tags
Unknown

Event Timeline

Gavin Andresen <gavinandresen@gmail.com> committed rSTAGINGca4cf5cff6fb: Wallet locking fixes for -DDEBUG_LOCKORDER (authored by Gavin Andresen <gavinandresen@gmail.com>).Feb 18 2014, 17:11