HomePhabricator

autotools: fix a parallel build race condition spotted by the pull-tester
cae63be6c95bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

autotools: fix a parallel build race condition spotted by the pull-tester

libleveldb.a and libmemenv.a should be able to build in parallel, but in
practice calling the leveldb makefile ends up rewriting build_config.mk. If
one target tries to build while the other is halfway through writing the
.mk, the make ends up in an undefined state.

Fix that by making one depend on the other. This also reorders the variables
to be passed by param rather than via the environment, and combines the targets
into a single rule to avoid needless duplication.

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Sep 16 2013, 05:22
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING2975db76b3c6: Merge pull request #2996 from theuni/qt-translation
Branches
Unknown
Tags
Unknown

Event Timeline

Cory Fields <cory-nospam-@coryfields.com> committed rSTAGINGcae63be6c95b: autotools: fix a parallel build race condition spotted by the pull-tester (authored by Cory Fields <cory-nospam-@coryfields.com>).Sep 16 2013, 05:59