HomePhabricator

Prevent socket leak in ThreadSocketHandler.
d20791b0e524Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Prevent socket leak in ThreadSocketHandler.

When we are over our outbound limit ThreadSocketHandler would try to
keep the connection if the peer was addnoded.

This didn't actually work for two reasons: It didn't actually run
the accept code due to mistaken code flow, and because we have a
limited number of outbound semaphores it couldn't actually use the
connection.

Instead it leaked the socket, which might have caused issue #4034.

This patch just takes out the non-functioning white-listing for now.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Apr 9 2014, 16:25
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING20ecf5c27d80: Merge pull request #4024
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGINGd20791b0e524: Prevent socket leak in ThreadSocketHandler. (authored by Gregory Maxwell <greg@xiph.org>).Apr 9 2014, 16:30