HomePhabricator

Remove SingleNodeConnCB

Description

Remove SingleNodeConnCB

Summary:
This commit merges the NodeConnCB and SingleNodeConnCB into a single
class (called NodeConnCB). The original intent for the NodeConnCB was to
be able to have a python 'mininode' connect to multiple running
bitcoinds. This has never been used and can be achieved more easily by
having multiple NodeConns backed by a common datastore if it is ever
needed.

The changes in mininode.py are just code moves (and merging the two
classes into a single class). The code changes in the individual test
cases are changing the subclasses to subclass from NodeConnCB instead of
SingleNodeConnCB. There is a lot of duplicate code in the subclasses
that can be removed in future commits.

Backport of Core PR10109, Fixes T143

Test Plan: Run functional tests

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity

Maniphest Tasks: T143

Differential Revision: https://reviews.bitcoinabc.org/D968

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Mar 28 2017, 17:41
schancelCommitted on Jan 19 2018, 02:02
schancelPushed on Jan 20 2018, 00:51
Reviewer
Restricted Project
Differential Revision
D968: Remove SingleNodeConnCB
Parents
rSTAGING34326d640836: Cleaned up last usages of nHashType
Branches
Unknown
Tags
Unknown
Tasks
T143: Remove SingleNodeConnCB