HomePhabricator

Add missing cs_main lock to ::GETBLOCKTXN processing
dfe79060a62cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add missing cs_main lock to ::GETBLOCKTXN processing

Note that this is not a major issue as, in order for the missing
lock to cause issues, you have to receive a GETBLOCKTXN message
while reindexing, adding a block header via RPC, etc, which results
in either a table rehash or an insert into the bucket which you are
currently looking at.

Details

Provenance
Matt Corallo <git@bluematt.me>Authored on Oct 21 2016, 16:15
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING3cf496d102d2: Merge #8968: Don't hold cs_main when calling ProcessNewBlock from a cmpctblock
Branches
Unknown
Tags
Unknown

Event Timeline

Matt Corallo <git@bluematt.me> committed rSTAGINGdfe79060a62c: Add missing cs_main lock to ::GETBLOCKTXN processing (authored by Matt Corallo <git@bluematt.me>).Oct 21 2016, 16:15