HomePhabricator
Diffusion Bitcoin ABC staging e2195037116f

Fix memleak in TorController [rework]
e2195037116fUnpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix memleak in TorController [rework]

It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Mar 3 2016, 12:28
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING1b68de35250e: Merge #7620: [travis] Only run check-doc.py once
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGINGe2195037116f: Fix memleak in TorController [rework] (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Mar 3 2016, 12:31

Changes (1)

PathSize
src/

rSTAGINGe2195037116f

View Options

src/torcontrol.cpp

Loading...