HomePhabricator

Avoid ugly exception in log on unknown inv type
e9f25ddd0063Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Avoid ugly exception in log on unknown inv type

It is unexpected behavior for ToString to raise an exception. It
is expected to do a best-effort attempt at formatting but never fail.

Catch the exception and simply print unknown inv types as hexadecimal.

Fixes #9110.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 9 2016, 10:09
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGe9847303e708: Merge #8874: Multiple Selection for peer and ban tables
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGINGe9f25ddd0063: Avoid ugly exception in log on unknown inv type (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Nov 9 2016, 10:16