HomePhabricator

Move orphan processing to ActivateBestChain
ec4525ccc1c1Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Move orphan processing to ActivateBestChain

This further decouples "main" and "net" processing logic by moving
orphan processing out of the chain-connecting cs_main lock and
into its own cs_main lock, beside all of the other chain callbacks.

Once further decoupling of net and main processing logic occurs,
orphan handing should move to its own lock, out of cs_main.

Note that this will introduce a race if there are any cases where
we assume the orphan map to be consistent with the current chain
tip, however I am confident there is no such case (ATMP will fail
without DoS score in all such cases).

Details

Provenance
Matt Corallo <git@bluematt.me>Authored on Oct 15 2016, 21:34
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING9346f8429957: Merge #9075: Decouple peer-processing-logic from block-connection-logic (#3)
Branches
Unknown
Tags
Unknown

Event Timeline

Matt Corallo <git@bluematt.me> committed rSTAGINGec4525ccc1c1: Move orphan processing to ActivateBestChain (authored by Matt Corallo <git@bluematt.me>).Nov 18 2016, 01:10