HomePhabricator

wallet: Get rid of LockObject and UnlockObject calls in key.h
f4d1fc259b5aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

wallet: Get rid of LockObject and UnlockObject calls in key.h

Replace these with vectors allocated from the secure allocator.

This avoids mlock syscall churn on stack pages, as well as makes
it possible to get rid of these functions.

Please review this commit and the previous one carefully that
no sizeof(vectortype) remains in the memcpys and memcmps usage
(ick!), and .data() or &vec[x] is used as appropriate instead of
&vec.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 18 2016, 06:40
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING999e4c91c2cd: wallet: Change CCrypter to use vectors with secure allocator
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGINGf4d1fc259b5a: wallet: Get rid of LockObject and UnlockObject calls in key.h (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Oct 19 2016, 14:17