HomePhabricator

Inline signature serializer
f5857e5cb5fbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Inline signature serializer

Instead of building a full copy of a CTransaction being signed, and
then modifying bits and pieces until its fits the form necessary
for computing the signature hash, use a wrapper serializer that
only serializes the necessary bits on-the-fly.

This makes it easier to see which data is actually being hash,
reduces load on the heap, and also marginally improves performances
(around 3-4us/sigcheck here). The performance improvements are much
larger for large transactions, though.

The old implementation of SignatureHash is moved to a unit tests,
to test whether the old and new algorithm result in the same value
for randomly-constructed transactions.

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on May 4 2013, 17:32
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGb41fa66ba7ea: Merge pull request #3034 from fanquake/corect-qt-download-link
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rSTAGINGf5857e5cb5fb: Inline signature serializer (authored by Pieter Wuille <pieter.wuille@gmail.com>).Sep 28 2013, 16:37