HomePhabricator

Longer term workaround for chainstate corruption from negative versions.
f8b7aa862519Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Longer term workaround for chainstate corruption from negative versions.

This also makes negative transaction versions non-standard.

This avoids an issue triggered in block 256818 where transactions with
negative version numbers were incorrectly serialized into the UTXO set.

On restart nodes detect the inconsistency and refuse to start so long as
a block with these transactions is inside the self-consistency check
window, logging "coin database inconsistencies found". The software
recommends reindexing, but reindexing does not correct the problem.

This should be fixed by changing the chainstate serialization, but
working around it seems harmless for now because the version is not
used by any network rule currently.

A patch free workaround is to start with -checklevel=2 which skips
the consistency checks, but the IsStandard change is important for
miners in order to protect unpatched nodes.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Sep 9 2013, 09:11
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING4c723841e256: Merge pull request #2968 from TheBlueMatt/master
Branches
Unknown
Tags
Unknown

Event Timeline