Paths

Table of Contentst

Differential D10003

walletdb: Add MakeBatch function to BerkeleyDatabase and use it
ClosedPublic
Actions

Authored by PiRK on Sep 1 2021, 08:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcbd256fb3562: walletdb: Add MakeBatch function to BerkeleyDatabase and use it

Summary

Instead of having WalletBatch construct the BerkeleyBatch, have
BerkeleyDatabase do it and return a std::unique_ptr<BerkeleyBatch>

This is a backport of core#19325 [2/2]
https://github.com/bitcoin/bitcoin/pull/19325/commits/b82f0ca4d5465b36debb6c57f335bdccf4899c49

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19325

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16503
Build 32868: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 32867: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 1 2021, 08:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2021, 08:30

PiRK requested review of this revision.Sep 1 2021, 08:30

teamcity edited the summary of this revision. (Show Details)Sep 1 2021, 08:30

Harbormaster completed remote builds in B16503: Diff 29712.Sep 1 2021, 08:47

Fabien accepted this revision.Sep 1 2021, 09:09

This revision is now accepted and ready to land.Sep 1 2021, 09:09

Closed by commit rABCcbd256fb3562: walletdb: Add MakeBatch function to BerkeleyDatabase and use it (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 1 2021, 09:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcbd256fb3562: walletdb: Add MakeBatch function to BerkeleyDatabase and use it.

Revision Contents
Changeset List

Path

Size

src/

wallet/

6 lines

5 lines

13 lines

38 lines

Diff 29712

View Options

src/wallet/bdb.h

View Options

src/wallet/bdb.cpp

View Options

src/wallet/walletdb.h

View Options

walletdb: Add MakeBatch function to BerkeleyDatabase and use itClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29712

src/wallet/bdb.h

src/wallet/bdb.cpp

src/wallet/walletdb.h

src/wallet/walletdb.cpp

walletdb: Add MakeBatch function to BerkeleyDatabase and use it
ClosedPublic
Actions

Revision Contents
Changeset List