rpc: deduplicate WriteHDKeypath() used in decodepsbt
ClosedPublic
Actions

Authored by PiRK on Sep 2 2021, 07:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC67d86464578b: rpc: deduplicate WriteHDKeypath() used in decodepsbt

Summary

The functionality is already provided in the BIP32 utility library util/bip32.h
with the exact same name and function signature.

This is a backport of core#19555

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19555

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16515
Build 32892: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-clang · build-debug
Build 32891: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 2 2021, 07:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2021, 07:36

PiRK requested review of this revision.Sep 2 2021, 07:36

teamcity edited the summary of this revision. (Show Details)Sep 2 2021, 07:36

Harbormaster completed remote builds in B16515: Diff 29734.Sep 2 2021, 07:50

Fabien accepted this revision.Sep 2 2021, 07:51

This revision is now accepted and ready to land.Sep 2 2021, 07:51

Closed by commit rABC67d86464578b: rpc: deduplicate WriteHDKeypath() used in decodepsbt (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhySep 2 2021, 08:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC67d86464578b: rpc: deduplicate WriteHDKeypath() used in decodepsbt.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

19 lines

Diff 29734

View Options

src/rpc/rawtransaction.cpp

rpc: deduplicate WriteHDKeypath() used in decodepsbtClosedPublicActions