tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx
ClosedPublic
Actions

Authored by PiRK on Sep 2 2021, 20:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC51eafd40925e: tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx

Summary

D9989 broke src/test/test_bitcoin. This was not noticed until now
because most of the time we run the tests via ninja check, which
didn't fail (presumably because with ninja check there are not
concurrent wallets loaded at the same time).

This fixes it by using the common node context from BasicTestingSetup
to load the wallet, rather than creating a fresh NodeContext.

Test Plan

ninja && ninja check
ninja test_bitcoin && src/test/test_bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 2 2021, 20:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2021, 20:15

PiRK requested review of this revision.Sep 2 2021, 20:15

PiRK retitled this revision from tests: fix ZapSelectTx in wallet_tests to tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx.Sep 2 2021, 20:17

PiRK edited the summary of this revision. (Show Details)Sep 2 2021, 20:22

Harbormaster completed remote builds in B16531: Diff 29764.Sep 2 2021, 20:27

PiRK added a child revision: D10030: tests: Add script checking for deterministic line coverage.Sep 3 2021, 07:04

Fabien accepted this revision.Sep 3 2021, 08:30

This revision is now accepted and ready to land.Sep 3 2021, 08:30

Closed by commit rABC51eafd40925e: tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx (authored by PiRK). · Explain WhySep 3 2021, 14:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC51eafd40925e: tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx.