Page MenuHomePhabricator

tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx
ClosedPublic

Authored by PiRK on Thu, Sep 2, 20:15.

Details

Summary

D9989 broke src/test/test_bitcoin. This was not noticed until now
because most of the time we run the tests via ninja check, which
didn't fail (presumably because with ninja check there are not
concurrent wallets loaded at the same time).

This fixes it by using the common node context from BasicTestingSetup
to load the wallet, rather than creating a fresh NodeContext.

Test Plan
ninja && ninja check
ninja test_bitcoin && src/test/test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Thu, Sep 2, 20:15
PiRK retitled this revision from tests: fix ZapSelectTx in wallet_tests to tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx.Thu, Sep 2, 20:17
This revision is now accepted and ready to land.Fri, Sep 3, 08:30