Page MenuHomePhabricator
Differential D10032

[avalanche] Cache the peer score
ClosedPublic
Actions

Authored by Fabien on Sep 3 2021, 13:33.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCa839bb735777: [avalanche] Cache the peer score
Summary

Since it is not possible to update the score for a proof at the moment, we can cache the value to avoid recomputing every time. This especially makes sense after D10031 since the proof score is used as a key for the peer set.

This is an optimization only and does not change the behavior.

Ref T1864.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Sep 3 2021, 13:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 13:33
Fabien requested review of this revision.Sep 3 2021, 13:33
Harbormaster completed remote builds in B16535: Diff 29768.Sep 3 2021, 13:47
PiRK accepted this revision.Sep 3 2021, 14:47
This revision is now accepted and ready to land.Sep 3 2021, 14:47
Fabien planned changes to this revision.Sep 28 2021, 19:05
Fabien edited the summary of this revision. (Show Details)Nov 23 2021, 13:34
Fabien added a task: Restricted Maniphest Task.
Fabien updated this revision to Diff 30945.Nov 23 2021, 14:22

Rebase, revive

This revision is now accepted and ready to land.Nov 23 2021, 14:22
Harbormaster completed remote builds in B17308: Diff 30945.Nov 23 2021, 14:47
Fabien planned changes to this revision.Jan 28 2022, 19:18

Will revive later if needed

Fabien updated this revision to Diff 32508.Feb 23 2022, 17:44

Rebase

This revision is now accepted and ready to land.Feb 23 2022, 17:44
Harbormaster completed remote builds in B18351: Diff 32508.Feb 23 2022, 18:07
Fabien edited the summary of this revision. (Show Details)Feb 24 2022, 13:59
Fabien added a task: Restricted Maniphest Task.
Fabien removed a task: Restricted Maniphest Task.
Closed by commit rABCa839bb735777: [avalanche] Cache the peer score (authored by Fabien). · Explain WhyFeb 24 2022, 14:08
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa839bb735777: [avalanche] Cache the peer score.

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
4 lines

Diff 29768

View Options

src/avalanche/proof.h

Loading...
View Options

src/avalanche/proof.cpp

Loading...