Page MenuHomePhabricator
Differential D10053

Move filtering banned addrs inside GetAddresses()
ClosedPublic
Actions

Authored by PiRK on Sep 6 2021, 16:11.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5c9fac955c4a: Move filtering banned addrs inside GetAddresses()
Summary

This is a backport of core#18991 [1/5]
https://github.com/bitcoin/bitcoin/pull/18991/commits/ded742bc5b96e3215d69c11fb3628d224e7ae034

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 6 2021, 16:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2021, 16:11
PiRK requested review of this revision.Sep 6 2021, 16:11
teamcity edited the summary of this revision. (Show Details)Sep 6 2021, 16:11
PiRK added a child revision: D10054: Remove useless 2500 limit on AddrMan queries.Sep 6 2021, 16:14
Harbormaster completed remote builds in B16566: Diff 29817.Sep 6 2021, 16:40
majcosta requested changes to this revision.Sep 6 2021, 16:59
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/net.cpp
2868

well this kind of defeats the purpose now, doesn't it? :-)

This revision now requires changes to proceed.Sep 6 2021, 16:59
PiRK added inline comments.Sep 6 2021, 19:20
src/net.cpp
2868

I'm a bit embarrassed.

PiRK updated this revision to Diff 29822.Sep 6 2021, 19:48

remove extra line

Harbormaster completed remote builds in B16571: Diff 29822.Sep 6 2021, 20:00
majcosta accepted this revision.Sep 6 2021, 21:36
This revision is now accepted and ready to land.Sep 6 2021, 21:36
Closed by commit rABC5c9fac955c4a: Move filtering banned addrs inside GetAddresses() (authored by Gleb Naumenko <naumenko.gs@gmail.com>, committed by PiRK). · Explain WhySep 7 2021, 07:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5c9fac955c4a: Move filtering banned addrs inside GetAddresses().

Revision Contents
Changeset List

PathSize
src/
11 lines
7 lines

Diff 29817

View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...