refactor: test: use _ variable for unused loop counters
ClosedPublic
Actions

Authored by PiRK on Sep 7 2021, 15:16.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7b81a4a8aac4: refactor: test: use _ variable for unused loop counters

Summary

substitutes "for x in range(N):" by "for _ in range(N):"
indicates to the reader that a block is just repeated N times, and
that the loop counter is not used in the body

Backport notes:

this PR also replaces a few occurences of range(0, x) with range(x)
test/functional/p2p_tx_download.py has been included in test/functional/p2p_inv_download.py, and was already up to date

This is a backport of core#19674

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19674

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16583
Build 33021: Build Diff	build-clang · build-diff · build-without-wallet · build-debug · build-clang-tidy
Build 33020: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 7 2021, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2021, 15:16

PiRK requested review of this revision.Sep 7 2021, 15:16

teamcity edited the summary of this revision. (Show Details)Sep 7 2021, 15:16

Additional note: I had a quick look to see if there is an automated linter solution (autopep8...) for this. I couldn't find any.

Using _ as a throwaway variable is an often used idiom in python, but it is not universally considered a good practice. It can conflict with _ used as an internationalization function name. An alternative would be _i.

teamcity edited the summary of this revision. (Show Details)Sep 7 2021, 15:21

Harbormaster completed remote builds in B16583: Diff 29848.Sep 7 2021, 15:31

majcosta accepted this revision.Sep 7 2021, 15:56

This revision is now accepted and ready to land.Sep 7 2021, 15:56

PiRK edited the summary of this revision. (Show Details)Sep 8 2021, 06:45

Closed by commit rABC7b81a4a8aac4: refactor: test: use _ variable for unused loop counters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhySep 8 2021, 06:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7b81a4a8aac4: refactor: test: use _ variable for unused loop counters.

PiRK mentioned this in D10345: test: use _ variable for unused loop counters (follow-up).Oct 14 2021, 14:50

PiRK mentioned this in rABCa5d65ce0486e: test: use _ variable for unused loop counters (follow-up).Oct 14 2021, 15:44