Page MenuHomePhabricator
Differential D10091

rpc generate: print useful help and error message
ClosedPublic
Actions

Authored by PiRK on Sep 13 2021, 08:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC803956cc1653: rpc generate: print useful help and error message
Summary

PR rationale:

This was a requested follow-up to #19133 and #17700 to alleviate confusion and head-scratching by people following tutorials that use generate.

test: consider generate covered in _get_uncovered_rpc_commands()

rpc: print useful help and error message for generate

test: add rpc_generate functional test

This is a backport of core#19455

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 13 2021, 08:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 08:15
PiRK requested review of this revision.Sep 13 2021, 08:15
Harbormaster completed remote builds in B16612: Diff 29898.Sep 13 2021, 08:31
Fabien added a subscriber: Fabien.Sep 13 2021, 16:24

Is that a backport ?

PiRK edited the summary of this revision. (Show Details)Sep 14 2021, 06:40
In D10091#227354, @Fabien wrote:

Is that a backport ?

Yes, sorry about that. I added the information in the description, and also the rationale for this change.

Fabien accepted this revision.Sep 14 2021, 09:03
This revision is now accepted and ready to land.Sep 14 2021, 09:03
PiRK updated this revision to Diff 29943.Sep 14 2021, 12:51

rebase

Harbormaster completed remote builds in B16639: Diff 29943.Sep 14 2021, 13:21
Closed by commit rABC803956cc1653: rpc generate: print useful help and error message (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhySep 14 2021, 16:34
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC803956cc1653: rpc generate: print useful help and error message.

Revision Contents
Changeset List

PathSize
src/
rpc/
14 lines
test/
functional/
38 lines
6 lines

Diff 29953

View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/rpc_generate.py

Loading...
View Options

test/functional/test_runner.py

Loading...