Page MenuHomePhabricator

rpc generate: print useful help and error message
ClosedPublic

Authored by PiRK on Mon, Sep 13, 08:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC803956cc1653: rpc generate: print useful help and error message
Summary

PR rationale:

This was a requested follow-up to #19133 and #17700 to alleviate confusion and head-scratching by people following tutorials that use generate.

test: consider generate covered in _get_uncovered_rpc_commands()

rpc: print useful help and error message for generate

test: add rpc_generate functional test

This is a backport of core#19455

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Sep 13, 08:15

Is that a backport ?

Yes, sorry about that. I added the information in the description, and also the rationale for this change.

This revision is now accepted and ready to land.Tue, Sep 14, 09:03