Page MenuHomePhabricator

[avalanche] Add a payout script to the proof
AcceptedPublic

Authored by Fabien on Tue, Sep 14, 12:46.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Summary

This will be used for stake rewards. Since it's changing the proof format, I hid it behind a flag so I don't have to update all the tests, especially since more format changes are coming (and updating the hardcoded proofs in tests is expensive).

The payout script cannot be changed without signing the stakes again. This will change in the future.

Ref T1676.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien requested review of this revision.Tue, Sep 14, 12:46
Fabien planned changes to this revision.Wed, Sep 15, 13:58
Fabien retitled this revision from [avalanche] Add a payout address to the proof to [avalanche] Add a payout script to the proof.Thu, Sep 16, 10:45
Fabien edited the summary of this revision. (Show Details)

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/proof" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegation -> avalanche/proof -> core_io -> psbt -> node/transaction -> net -> avalanche/delegation" appears to have been introduced.

A new circular dependency in the form of "avalanche/peermanager -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/peermanager" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegationbuilder -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/delegationbuilder" appears to have been introduced.

A new circular dependency in the form of "avalanche/peermanager -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/peermanager" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegation -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/protocol -> avalanche/delegation" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Fix the circular dependency

This revision is now accepted and ready to land.Thu, Sep 16, 14:28