Differential D10109

[avalanche] Add a payout script to the proof
ClosedPublic
Actions

Authored by Fabien on Sep 14 2021, 12:46.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC14119cb873ee: [avalanche] Add a payout script to the proof

Summary

This will be used for stake rewards. Since it's changing the proof format, I hid it behind a flag so I don't have to update all the tests, especially since more format changes are coming (and updating the hardcoded proofs in tests is expensive).

The payout script cannot be changed without signing the stakes again. This will change in the future.

Ref T1676.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 14 2021, 12:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2021, 12:46

Fabien requested review of this revision.Sep 14 2021, 12:46

Harbormaster completed remote builds in B16638: Diff 29941.Sep 14 2021, 13:02

Fabien planned changes to this revision.Sep 15 2021, 13:58

Fabien retitled this revision from [avalanche] Add a payout address to the proof to [avalanche] Add a payout script to the proof.Sep 16 2021, 10:45

Fabien edited the summary of this revision. (Show Details)

Fabien removed parent revisions: D10107: Allow for serializing/deserializing an ecash address, D10108: Add a facility to convert a CTxDestination to a CashAddrContent.

Use a script instead

Harbormaster completed remote builds in B16667: Diff 29989.Sep 16 2021, 10:57

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/proof" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegation -> avalanche/proof -> core_io -> psbt -> node/transaction -> net -> avalanche/delegation" appears to have been introduced.

A new circular dependency in the form of "avalanche/peermanager -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/peermanager" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegationbuilder -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/delegationbuilder" appears to have been introduced.

A new circular dependency in the form of "avalanche/peermanager -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/peermanager" appears to have been introduced.

A new circular dependency in the form of "avalanche/delegation -> avalanche/proof -> core_io -> psbt -> node/transaction -> net_processing -> avalanche/processor -> avalanche/protocol -> avalanche/delegation" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Fix the circular dependency

Harbormaster completed remote builds in B16668: Diff 29990.Sep 16 2021, 11:46

Fabien added a child revision: D10133: [avalanche] Let buildavalancheproof take a payout address.Sep 16 2021, 13:20

PiRK accepted this revision.Sep 16 2021, 14:28

This revision is now accepted and ready to land.Sep 16 2021, 14:28

Fabien added a child revision: D10140: [avalanche] Sign the avalanche proof.Sep 16 2021, 20:10

Fabien added a child revision: D10151: [avalanche] Only sign the subset of data we want to commit the stakes to.Sep 17 2021, 16:37

Fabien removed a child revision: D10151: [avalanche] Only sign the subset of data we want to commit the stakes to.Sep 22 2021, 10:02

Closed by commit rABC14119cb873ee: [avalanche] Add a payout script to the proof (authored by Fabien). · Explain WhySep 23 2021, 09:31

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC14119cb873ee: [avalanche] Add a payout script to the proof.

Fabien removed a child revision: D10140: [avalanche] Sign the avalanche proof.Sep 23 2021, 09:47