Fix spelling of "unreachable" in OP_CHECKMULTISIG
ClosedPublic
Actions

Authored by tobias_ruck on Sep 15 2021, 23:05.

Details

Reviewers

PiRK
Mengerian

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCe3c96f8ddab2: Fix spelling of "unreachable" in OP_CHECKMULTISIG

Summary

Wrong spelling of "unreachable" in the implementation of OP_CHECKMULTISIG/OP_CHECKMULTISIGVERIFY.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Sep 15 2021, 23:05

Owners added a reviewer: Restricted Owners Package.Sep 15 2021, 23:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2021, 23:05

tobias_ruck requested review of this revision.Sep 15 2021, 23:05

Harbormaster completed remote builds in B16663: Diff 29983.Sep 15 2021, 23:18

Can you also remove the extra e after the h, while you are at it.

This revision now requires changes to proceed.Sep 16 2021, 04:43

Actually fix the typo in "unreachable" in OP_CHECKMULTISIG

Harbormaster completed remote builds in B16664: Diff 29986.Sep 16 2021, 07:13

PiRK accepted this revision.Sep 16 2021, 08:57

This revision is now accepted and ready to land.Sep 16 2021, 08:57

It was wrong in multiple ways :)

LGTM.

I also checked that this typo isn't in Bitcoin Core, it originated with ABC here: https://reviews.bitcoinabc.org/D3474

Closed by commit rABCe3c96f8ddab2: Fix spelling of "unreachable" in OP_CHECKMULTISIG (authored by tobias_ruck). · Explain WhySep 16 2021, 16:29

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCe3c96f8ddab2: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

6 lines

Diff 30010

View Options

src/script/interpreter.cpp

Fix spelling of "unreachable" in OP_CHECKMULTISIGClosedPublicActions