refactor: Move wallet methods out of chain.h and node.h
ClosedPublic
Actions

Authored by PiRK on Sep 17 2021, 08:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6523a23ee893: refactor: Move wallet methods out of chain.h and node.h

Summary

https://github.com/bitcoin/bitcoin/pull/19099/commits/e4f435047121886edb6e6a6c4e4998e44ed2e36a

Add WalletClient interface so node interface is cleaner and don't need
wallet-specific methods.

The new NodeContext::wallet_client pointer will also be needed to eliminate
global wallet variables like ::vpwallets, because createWallet(), loadWallet(),
getWallets(), etc methods called by the GUI need a way to get a reference to
the list of open wallets if it is no longer a global variable.

Also tweaks splash screen registration for load wallet events to be delayed
until after wallet client is created.

https://github.com/bitcoin-core/gui/pull/102/commits/c056064a4a93be3601a63b37afea41f8b878df79

gui: Fix SplashScreen crash when run with -disablewallet

This is a backport of core#19099 [2/3] and core-gui#102 (small bugfix)

Depends on D10141

Test Plan

ninja all check-all

Test for bugfix core-gui#102: src/qt/bitcoin-qt -disablewallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16685
Build 33225: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 33224: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 17 2021, 08:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2021, 08:11

PiRK requested review of this revision.Sep 17 2021, 08:11

teamcity edited the summary of this revision. (Show Details)Sep 17 2021, 08:11

PiRK added a child revision: D10143: gui refactor: Inline SplashScreen::ConnectWallet.Sep 17 2021, 08:13

PiRK edited the summary of this revision. (Show Details)Sep 17 2021, 08:13

Harbormaster completed remote builds in B16685: Diff 30019.Sep 17 2021, 08:34

Fabien requested changes to this revision.Sep 17 2021, 09:09

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/test/wallet_test_fixture.h
29	you duplicated the wallet

This revision now requires changes to proceed.Sep 17 2021, 09:09

• boardgamesaz added a subscriber: • boardgamesaz.Sep 17 2021, 10:13

This comment was removed by Klakurka.

Remove #include <support/allocators/secure.h> from dummywallet.cpp in this commit (and not in the previous one),
fix duplicated MakeWalletClient call in wallet_test_fixture.h

Harbormaster completed remote builds in B16690: Diff 30024.Sep 17 2021, 11:57

Klakurka added a subscriber: Klakurka.Sep 17 2021, 22:06

Fabien accepted this revision.Sep 19 2021, 04:52

This revision is now accepted and ready to land.Sep 19 2021, 04:52

Closed by commit rABC6523a23ee893: refactor: Move wallet methods out of chain.h and node.h (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhySep 19 2021, 07:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6523a23ee893: refactor: Move wallet methods out of chain.h and node.h.