Page MenuHomePhabricator

remove unnecessary newline at the start of RPC help descriptions
ClosedPublic

Authored by PiRK on Sep 19 2021, 08:45.

Details

Summary

D7184 made it unnecessary to start the description of a help message
with a \n, and fixed most messages accordingly. But it missed a few, and
few more were recently backported without removing the extra newline.

Before:

$ src/bitcoin-cli help importmulti
importmulti "requests" ( "options" )


Import addresses/scripts (with private or public keys,...

After:

$ src/bitcoin-cli help importmulti
importmulti "requests" ( "options" )

Import addresses/scripts (with private or public keys,...
Test Plan

pcregrep -M -r 'RPCHelpMan{\n? *"\w+",\n? *"\\n' src/

Check that the result looks good:

src/bitcoin-cli help getblockcount
src/bitcoin-cli help dumptxoutset
src/bitcoin-cli help generatetodescriptor
src/bitcoin-cli help generateblock
src/bitcoin-cli help getindexinfo
src/bitcoin-cli help addpeeraddress
src/bitcoin-cli help importmulti
src/bitcoin-cli help importdescriptors
src/bitcoin-cli help getaddressinfo
src/bitcoin-cli help upgradewallet

Diff Detail