Page MenuHomePhabricator
Differential D10160

Remove -zapwallettxes
ClosedPublic
Actions

Authored by PiRK on Sep 20 2021, 09:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC64f1961e185b: Remove -zapwallettxes
Summary

-zapwallettxes is made a hidden option to inform users that it is
removed and they should be using abandontransaction to do the stuck
transaction thing.

This is a backport of core#19671

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 20 2021, 09:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2021, 09:24
PiRK requested review of this revision.Sep 20 2021, 09:24
teamcity edited the summary of this revision. (Show Details)Sep 20 2021, 09:24
Harbormaster completed remote builds in B16719: Diff 30065.Sep 20 2021, 09:39
Fabien requested changes to this revision.Sep 20 2021, 12:33
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/init.cpp
139 ↗(On Diff #30065)

It is supposed to move to hidden args

src/wallet/wallet.cpp
4216 ↗(On Diff #30065)

Keep

This revision now requires changes to proceed.Sep 20 2021, 12:33
PiRK updated this revision to Diff 30079.Sep 20 2021, 12:49

fix two conflict resolution accidents

Harbormaster completed remote builds in B16728: Diff 30079.Sep 20 2021, 13:03
PiRK planned changes to this revision.Sep 21 2021, 11:14

Needs rebasing after D10170 is merged

PiRK updated this revision to Diff 30096.Sep 21 2021, 12:31

rebase after version bump (hadle conflict in release-notes.md)

Harbormaster completed remote builds in B16742: Diff 30096.Sep 21 2021, 12:54
Fabien accepted this revision.Sep 21 2021, 17:11
This revision is now accepted and ready to land.Sep 21 2021, 17:11
Closed by commit rABC64f1961e185b: Remove -zapwallettxes (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 22 2021, 08:04
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC64f1961e185b: Remove -zapwallettxes.

Revision Contents
Changeset List

PathSize
doc/
3 lines
src/
2 lines
wallet/
36 lines
2 lines
1 line
57 lines
1 line
18 lines
test/
functional/
2 lines
20 lines
lint/
2 lines

Diff 30101

View Options

doc/release-notes.md

Loading...
View Options

src/dummywallet.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...
View Options

test/functional/wallet_basic.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...
View Options

test/functional/wallet_zapwallettxes.py

Loading...
View Options

test/lint/check-doc.py

Loading...