Page MenuHomePhabricator
Differential D10165

doc: Add best practice for annotating/asserting locks
ClosedPublic
Actions

Authored by PiRK on Sep 20 2021, 10:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCac7014aca8fb: doc: Add best practice for annotating/asserting locks
Summary

Backport note: I removed the paragraph about LockAssertion, because the code example causes a false positive linter error, and this paragraph would anyway get removed anyway in a few commits (D10173)

This is a backport of core#19668 [5/5]
https://github.com/bitcoin/bitcoin/pull/19668/commits/ea74e10acf17903e44c85e3678853414653dd4e1

Test Plan

proofreading

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr19668
Lint
Lint Errors
SeverityLocationCodeMessage
Errordoc/developer-notes.md:795lint-markdown1Dead link
Unit
No Test Coverage
Build Status
Buildable 16724
Build 33298: Build Diff
Build 33297: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 20 2021, 10:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2021, 10:32
PiRK requested review of this revision.Sep 20 2021, 10:32
Harbormaster completed remote builds in B16724: Diff 30075.Sep 20 2021, 10:32
teamcity edited the summary of this revision. (Show Details)Sep 20 2021, 10:32
PiRK added inline comments.Sep 20 2021, 10:35
doc/developer-notes.md
795

The linter error is a false positive

PiRK updated this revision to Diff 30077.Sep 20 2021, 10:58

rebase

Harbormaster completed remote builds in B16726: Diff 30077.Sep 20 2021, 10:58
PiRK updated this revision to Diff 30091.Sep 21 2021, 12:08
PiRK edited the summary of this revision. (Show Details)

remove the example that causes a linter error, as it would get removed anyway when backporting core#19979

Harbormaster completed remote builds in B16737: Diff 30091.Sep 21 2021, 12:09
PiRK edited the summary of this revision. (Show Details)Sep 21 2021, 12:22
Fabien accepted this revision.Sep 22 2021, 07:12
This revision is now accepted and ready to land.Sep 22 2021, 07:12
Closed by commit rABCac7014aca8fb: doc: Add best practice for annotating/asserting locks (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 22 2021, 08:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCac7014aca8fb: doc: Add best practice for annotating/asserting locks.

Revision Contents
Changeset List

PathSize
doc/
61 lines

Diff 30075

View Options

doc/developer-notes.md

Loading...