in protocol.cpp
ClosedPublic
Actions

Authored by PiRK on Sep 22 2021, 12:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC47b8417175dd: refactor: remove unused header <arpa/inet.h> in protocol.cpp

Summary

There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed.

This is a backport of core#19890

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 22 2021, 12:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2021, 12:55

PiRK requested review of this revision.Sep 22 2021, 12:55

teamcity edited the summary of this revision. (Show Details)Sep 22 2021, 12:56

Harbormaster completed remote builds in B16757: Diff 30125.Sep 22 2021, 13:24

Fabien accepted this revision.Sep 22 2021, 15:47

This revision is now accepted and ready to land.Sep 22 2021, 15:47

@bot gitian-win

teamcity awarded a token.Sep 22 2021, 15:48

Closed by commit rABC47b8417175dd: refactor: remove unused header <arpa/inet.h> in protocol.cpp (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhySep 23 2021, 07:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC47b8417175dd: refactor: remove unused header <arpa/inet.h> in protocol.cpp.

Revision Contents
Changeset List

Path

Size

src/

protocol.cpp

3 lines

Diff 30135

View Options

refactor: remove unused header <arpa/inet.h> in protocol.cppClosedPublicActions