Page MenuHomePhabricator
Differential D10185

Add loadwallet and createwallet RPC load_on_startup options
ClosedPublic
Actions

Authored by PiRK on Sep 22 2021, 14:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC62bae4b8a97f: Add loadwallet and createwallet RPC load_on_startup options
Summary

This maintains a persistent list of wallets stored in settings that will
automatically be loaded on startup. Being able to load a wallet automatically
on startup will be more useful in the GUI when the option to create wallets is
added in #15006, but it's reasonable to expose this feature by RPC as well.

This is a backport of core#15937

I had to include the RPCOverloadWrapper.createwallet method that should normally be added in D8671 in test_node.py. D8671 is going to take a bit longer to be backported, and the inclusion of CreateWallet here does not break anything or change any behavior, as descriptors will remain False for now.
See D9101 for why if load_on_startup is None: load_on_startup = 'null' is necessary.

Test Plan

ninja all check-all

To be sure the change in test_node.py didn't break any test:
ninja check-functional-extended

Diff Detail

Event Timeline

PiRK created this revision.Sep 22 2021, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2021, 14:36
PiRK requested review of this revision.Sep 22 2021, 14:36
teamcity edited the summary of this revision. (Show Details)Sep 22 2021, 14:36
Harbormaster completed remote builds in B16758: Diff 30126.Sep 22 2021, 14:50
Fabien requested changes to this revision.Sep 22 2021, 16:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
23 ↗(On Diff #30126)

newline

This revision now requires changes to proceed.Sep 22 2021, 16:00
PiRK updated this revision to Diff 30128.EditedSep 22 2021, 16:24

rebase onto master, fix conflict in release-notes and add missing newline

Harbormaster completed remote builds in B16759: Diff 30128.Sep 22 2021, 16:44
teamcity added a comment.Sep 22 2021, 16:45
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 32 s
rpc_rawtransaction.py                   | ✓ Passed  | 12 s
rpc_scantxoutset.py                     | ✓ Passed  | 3 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 5 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 4 s
wallet_abandonconflict.py               | ✓ Passed  | 9 s
wallet_address_types.py                 | ✓ Passed  | 13 s
wallet_avoidreuse.py                    | ✓ Passed  | 4 s
wallet_backup.py                        | ✓ Passed  | 25 s
wallet_balance.py                       | ✓ Passed  | 19 s
wallet_basic.py                         | ✓ Passed  | 18 s
wallet_coinbase_category.py             | ✓ Passed  | 1 s
wallet_create_tx.py                     | ✓ Passed  | 5 s
wallet_createwallet.py                  | ✓ Passed  | 2 s
wallet_createwallet.py --usecli         | ✓ Passed  | 3 s
wallet_descriptor.py                    | ✓ Passed  | 6 s
wallet_disable.py                       | ✓ Passed  | 1 s
wallet_dump.py                          | ✓ Passed  | 4 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_hd.py                            | ✓ Passed  | 6 s
wallet_import_rescan.py                 | ✓ Passed  | 4 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importdescriptors.py             | ✓ Passed  | 5 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 14 s
wallet_listsinceblock.py                | ✓ Passed  | 3 s
wallet_listtransactions.py              | ✓ Passed  | 13 s
wallet_multiwallet.py                   | ✓ Passed  | 40 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 12 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 17 s
wallet_startup.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py                     | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s

ALL                                     | ✓ Passed  | 983 s (accumulated) 
Runtime: 198 s

----------------------------------------------------------------------
Ran 8 tests in 0.009s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK updated this revision to Diff 30136.Sep 23 2021, 08:35

rebase and fix another conflict in release notes.

Harbormaster completed remote builds in B16762: Diff 30136.Sep 23 2021, 08:50
PiRK added a child revision: D10189: wallet: Reload previously loaded wallets on GUI startup.Sep 23 2021, 12:54
Fabien requested changes to this revision.Sep 27 2021, 07:27
Fabien added inline comments.
doc/release-notes.md
10

Keep the line breaks consistent

This revision now requires changes to proceed.Sep 27 2021, 07:27
PiRK updated this revision to Diff 30177.Sep 27 2021, 09:14

fix newline consistency in release-notes.md

Harbormaster completed remote builds in B16794: Diff 30177.Sep 27 2021, 09:52
Fabien accepted this revision.Sep 27 2021, 12:06
This revision is now accepted and ready to land.Sep 27 2021, 12:06
Closed by commit rABC62bae4b8a97f: Add loadwallet and createwallet RPC load_on_startup options (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhySep 27 2021, 12:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC62bae4b8a97f: Add loadwallet and createwallet RPC load_on_startup options.
PiRK mentioned this in D10213: Add a --descriptors option to various tests.Sep 29 2021, 13:57
PiRK mentioned this in rABCe854278f6db0: Add a --descriptors option to various tests.Oct 5 2021, 08:38

Revision Contents
Changeset List

PathSize
doc/
41 lines
src/
interfaces/
8 lines
21 lines
rpc/
3 lines
wallet/
11 lines
8 lines
35 lines
57 lines
test/
functional/
test_framework/
25 lines
50 lines

Diff 30136

View Options

doc/release-notes.md

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/load.h

Loading...
View Options

src/wallet/load.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/wallet_startup.py

Loading...