Paths

Table of Contentst

Differential D10209

refactor: Add BerkeleyDatabaseVersion() function
ClosedPublic
Actions

Authored by PiRK on Sep 28 2021, 15:57.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC85aad1446581: refactor: Add BerkeleyDatabaseVersion() function

Summary

This is a backport of core#16710 [1/2]
https://github.com/bitcoin/bitcoin/pull/16710/commits/de5e91c3034f320f84ee0308a3c31659635d136a

This is backported out of order. In the original PR, it should have touched db.{h|c}, but the code was moved to bdb.{h|c} in D8615. The original PR includes only db.h in rpcconsole.cpp, and bdb.h should have been added additionaly in D8615 (both includes will be needed for subsequent backports (e.g. core#20202).

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 28 2021, 15:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2021, 15:57

teamcity edited the summary of this revision. (Show Details)Sep 28 2021, 15:57

PiRK added a child revision: D10210: build: enable -Wsuggest-override.Sep 28 2021, 16:03

Harbormaster completed remote builds in B16800: Diff 30189.Sep 28 2021, 16:10

remove the #pragma change that belongs to the next commit, and explain in description why both db.h and bdb.h must be included in this change

Harbormaster completed remote builds in B16806: Diff 30197.Sep 29 2021, 07:53

This can be reviewed and landed independently of D10210.

Fabien accepted this revision.Sep 29 2021, 08:09

This revision is now accepted and ready to land.Sep 29 2021, 08:09

Closed by commit rABC85aad1446581: refactor: Add BerkeleyDatabaseVersion() function (authored by PiRK). · Explain WhySep 29 2021, 08:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC85aad1446581: refactor: Add BerkeleyDatabaseVersion() function.

Revision Contents
Changeset List

Path

Size

src/

qt/

8 lines

wallet/

2 lines

7 lines

Diff 30201

src/qt/rpcconsole.cpp

Loading...

src/wallet/bdb.h

Loading...

src/wallet/bdb.cpp

Loading...