build: enable -Wsuggest-override
AbandonedPublicDraft
Actions

Authored by PiRK on Sep 28 2021, 16:00.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Add override where it is missing, in invrequest.cpp

This is a backport of core#16710 [2/2]
https://github.com/bitcoin/bitcoin/pull/16710/commits/839add193b13c17a40f42ff69d973caeb800d3f2

Depends on D10209

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16710

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16807
Build 33463: Build Diff	build-without-wallet · build-clang · lint-circular-dependencies · build-clang-tidy · build-debug · build-diff
Build 33462: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 28 2021, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2021, 16:00

teamcity edited the summary of this revision. (Show Details)Sep 28 2021, 16:00

PiRK edited the summary of this revision. (Show Details)Sep 28 2021, 16:03

PiRK added a parent revision: D10209: refactor: Add BerkeleyDatabaseVersion() function.

Harbormaster completed remote builds in B16801: Diff 30190.Sep 28 2021, 16:06

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[353/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[354/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[355/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[356/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[357/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[358/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[359/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[360/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[361/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[362/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[363/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/test/util/setup_common.cpp:23:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[364/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[365/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[366/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[367/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o -c ../../src/interfaces/wallet.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/interfaces/wallet.cpp:15:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[370/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[371/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[372/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[373/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/wallet/rpcdump.cpp:11:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[376/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -c ../../src/wallet/rpcwallet.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/wallet/rpcwallet.cpp:19:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[377/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[353/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[354/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[355/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[356/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[357/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[358/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[359/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[360/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[361/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[362/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[363/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/test/util/setup_common.cpp:23:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[364/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[365/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[366/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[367/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[370/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[372/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o -c ../../src/interfaces/wallet.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/interfaces/wallet.cpp:15:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[373/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[376/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/wallet/rpcdump.cpp:11:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[377/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -c ../../src/wallet/rpcwallet.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/wallet/rpcwallet.cpp:19:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[337/456] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[338/456] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[339/456] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[340/456] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c ../../src/rpc/net.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/rpc/net.cpp:5:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[341/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[342/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[343/456] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[344/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[345/456] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[346/456] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[347/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[348/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[349/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[350/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[351/456] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[352/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[353/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[354/456] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[355/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[356/456] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o -MF src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o.d -o src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o -c ../../src/rpc/rawtransaction.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/rpc/rawtransaction.cpp:27:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[357/456] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/blockchain.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/blockchain.cpp.o -MF src/CMakeFiles/server.dir/rpc/blockchain.cpp.o.d -o src/CMakeFiles/server.dir/rpc/blockchain.cpp.o -c ../../src/rpc/blockchain.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/rpc/blockchain.cpp:26:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[358/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wsuggest-override -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/./rpc/server.h:11,
                 from ../../src/test/util/setup_common.cpp:23:
../../src/./rpc/command.h:60:14: error: ‘virtual UniValue RPCCommandWithArgsContext::Execute(const JSONRPCRequest&) const’ can be marked override [-Werror=suggest-override]
     UniValue Execute(const JSONRPCRequest &request) const final;
              ^~~~~~~
cc1plus: all warnings being treated as errors
[359/456] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

include the #pragma change that was previously included by mistake in D10209
Add an another override keyword in src/rpc/command.h. I cannot reproduce this warning locally, but it happens on CI.

CI does not show warnings for the leveldb code, but locally I'm getting a lot of them.

Harbormaster completed remote builds in B16807: Diff 30198.Sep 29 2021, 08:02

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

          ^~~~~~~~~~~~~
../../src/script/descriptor.cpp:728:10: error: ‘virtual bool {anonymous}::AddressDescriptor::IsSolvable() const’ can be marked override [-Werror=suggest-override]
     bool IsSolvable() const final { return false; }
          ^~~~~~~~~~
../../src/script/descriptor.cpp:740:10: error: ‘virtual bool {anonymous}::AddressDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:758:10: error: ‘virtual bool {anonymous}::RawDescriptor::IsSolvable() const’ can be marked override [-Werror=suggest-override]
     bool IsSolvable() const final { return false; }
          ^~~~~~~~~~
../../src/script/descriptor.cpp:772:10: error: ‘virtual bool {anonymous}::RawDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:787:10: error: ‘virtual bool {anonymous}::PKDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:807:10: error: ‘virtual bool {anonymous}::PKHDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:829:10: error: ‘virtual bool {anonymous}::ComboDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return false; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:859:10: error: ‘virtual bool {anonymous}::MultisigDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:877:10: error: ‘virtual bool {anonymous}::SHDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[351/509] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[352/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[353/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[354/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[355/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[356/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[357/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[358/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[359/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[360/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[361/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[363/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[364/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[365/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[366/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[367/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[372/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[373/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[376/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[377/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[379/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

          ^~~~~~~~~~~~~
../../src/script/descriptor.cpp:728:10: error: ‘virtual bool {anonymous}::AddressDescriptor::IsSolvable() const’ can be marked override [-Werror=suggest-override]
     bool IsSolvable() const final { return false; }
          ^~~~~~~~~~
../../src/script/descriptor.cpp:740:10: error: ‘virtual bool {anonymous}::AddressDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:758:10: error: ‘virtual bool {anonymous}::RawDescriptor::IsSolvable() const’ can be marked override [-Werror=suggest-override]
     bool IsSolvable() const final { return false; }
          ^~~~~~~~~~
../../src/script/descriptor.cpp:772:10: error: ‘virtual bool {anonymous}::RawDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:787:10: error: ‘virtual bool {anonymous}::PKDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:807:10: error: ‘virtual bool {anonymous}::PKHDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:829:10: error: ‘virtual bool {anonymous}::ComboDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return false; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:859:10: error: ‘virtual bool {anonymous}::MultisigDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
../../src/script/descriptor.cpp:877:10: error: ‘virtual bool {anonymous}::SHDescriptor::IsSingleType() const’ can be marked override [-Werror=suggest-override]
     bool IsSingleType() const final { return true; }
          ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[351/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[352/509] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[353/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[354/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[355/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[356/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[357/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[358/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[359/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[360/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[361/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[363/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[364/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[365/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[366/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[367/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[371/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[372/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[373/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[376/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[377/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[379/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

PiRK mentioned this in D10209: refactor: Add BerkeleyDatabaseVersion() function.Sep 29 2021, 08:03

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[303/456] Building CXX object src/CMakeFiles/server.dir/pow/daa.cpp.o
[304/456] Building CXX object src/CMakeFiles/server.dir/noui.cpp.o
[305/456] Building CXX object src/CMakeFiles/server.dir/pow/eda.cpp.o
[306/456] Building CXX object src/CMakeFiles/server.dir/pow/grasberg.cpp.o
[307/456] Building CXX object src/CMakeFiles/server.dir/node/context.cpp.o
[308/456] Building CXX object src/CMakeFiles/server.dir/rpc/command.cpp.o
[309/456] Building CXX object src/CMakeFiles/server.dir/pow/aserti32d.cpp.o
[310/456] Building CXX object src/CMakeFiles/server.dir/node/transaction.cpp.o
[311/456] Building CXX object src/CMakeFiles/server.dir/pow/pow.cpp.o
[312/456] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[313/456] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[314/456] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[315/456] Building CXX object src/CMakeFiles/server.dir/node/ui_interface.cpp.o
[316/456] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[317/456] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[318/456] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[319/456] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[320/456] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[321/456] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[322/456] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[323/456] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[324/456] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[325/456] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[326/456] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[327/456] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[328/456] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[329/456] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[330/456] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[331/456] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[332/456] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[333/456] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[334/456] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[335/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[336/456] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[337/456] Linking C static library src/secp256k1/libsecp256k1.a
[338/456] Linking CXX static library src/libcommon.a
[339/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[340/456] Linking C executable src/secp256k1/ecmult-bench
[341/456] Linking C executable src/secp256k1/internal-bench
[342/456] Linking C executable src/secp256k1/sign-bench
[343/456] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[344/456] Linking C executable src/secp256k1/verify-bench
[345/456] Linking C executable src/secp256k1/recover-bench
[346/456] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[347/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[348/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[349/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[350/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[351/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[352/456] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[353/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[354/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[355/456] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[356/456] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[357/456] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[358/456] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[359/456] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[360/456] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

It seems like we need to add additional override keywords where Core does not need them. Maybe a difference between compiler versions in how they handle methods that have the final keyword.

PiRK abandoned this revision.Apr 25 2023, 06:14